Skip to content

[Paywalls V2] Update CarouselComponent schema to new version with new…#2163

Merged
tonidero merged 2 commits into
paywalls-v2/carousel-rename-slide-to-pagefrom
update-carousel-schema-to-latest-version
Feb 14, 2025
Merged

[Paywalls V2] Update CarouselComponent schema to new version with new…#2163
tonidero merged 2 commits into
paywalls-v2/carousel-rename-slide-to-pagefrom
update-carousel-schema-to-latest-version

Conversation

@tonidero

Copy link
Copy Markdown
Contributor

Description

This makes the CarouselComponent schema updated to the latest version, with all the new properties we're supporting.

@tonidero tonidero requested review from a team, JayShortway and joshdholtz February 13, 2025 18:05
@tonidero tonidero marked this pull request as ready for review February 13, 2025 18:07
@emerge-tools

emerge-tools Bot commented Feb 13, 2025

Copy link
Copy Markdown

📸 Snapshot Test

2 modified, 1 added, 206 unchanged

Name Added Removed Modified Renamed Unchanged Errored Approval
TestPurchasesUIAndroidCompatibility
com.revenuecat.testpurchasesuiandroidcompatibility
1 0 2 0 206 0 ⏳ Needs approval

🛸 Powered by Emerge Tools

@codecov

codecov Bot commented Feb 13, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 76.92308% with 3 lines in your changes missing coverage. Please review.

Please upload report for BASE (paywalls-v2/carousel-rename-slide-to-page@95387c0). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...purchases/paywalls/components/CarouselComponent.kt 76.92% 3 Missing ⚠️
Additional details and impacted files
@@                             Coverage Diff                              @@
##             paywalls-v2/carousel-rename-slide-to-page    #2163   +/-   ##
============================================================================
  Coverage                                             ?   80.88%           
============================================================================
  Files                                                ?      275           
  Lines                                                ?     9306           
  Branches                                             ?     1296           
============================================================================
  Hits                                                 ?     7527           
  Misses                                               ?     1235           
  Partials                                             ?      544           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JayShortway JayShortway left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes a lot of sense!

@joshdholtz joshdholtz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!! :shipit:

@tonidero tonidero merged commit 35304b9 into paywalls-v2/carousel-rename-slide-to-page Feb 14, 2025
@tonidero tonidero deleted the update-carousel-schema-to-latest-version branch February 14, 2025 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants