Skip to content

[v6 HOTFIX] Fix amazon zero price (#1634)#1637

Merged
vegaro merged 1 commit into
release/6.9.6from
fix-on-6.9.6
Mar 7, 2024
Merged

[v6 HOTFIX] Fix amazon zero price (#1634)#1637
vegaro merged 1 commit into
release/6.9.6from
fix-on-6.9.6

Conversation

@vegaro

@vegaro vegaro commented Mar 7, 2024

Copy link
Copy Markdown
Member

Bringing #1634 on top of v6

We were never posting prices for Amazon purchases, because when we try
to find the purchased product, we where using the `subscriptionOptions`
property, which is always null for Amazon

This fix is a bit hacky right now, but we need to ship it quickly
@vegaro vegaro added the pr:fix A bug fix label Mar 7, 2024
@vegaro vegaro requested a review from a team March 7, 2024 14:29
@codecov

codecov Bot commented Mar 7, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 66.66667% with 3 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (release/6.9.6@e1466eb). Click here to learn what that means.

Files Patch % Lines
...rchases/PostTransactionWithProductDetailsHelper.kt 66.66% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##             release/6.9.6    #1637   +/-   ##
================================================
  Coverage                 ?   85.93%           
================================================
  Files                    ?      184           
  Lines                    ?     6277           
  Branches                 ?      911           
================================================
  Hits                     ?     5394           
  Misses                   ?      536           
  Partials                 ?      347           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vegaro vegaro merged commit ce67866 into release/6.9.6 Mar 7, 2024
@vegaro vegaro deleted the fix-on-6.9.6 branch March 7, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:fix A bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants