Paywalls: Move paywall view attributes parsing#1514
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## add-paywall-view #1514 +/- ##
=================================================
Coverage 84.50% 84.50%
=================================================
Files 218 218
Lines 7211 7211
Branches 1004 1004
=================================================
Hits 6094 6094
Misses 729 729
Partials 388 388 ☔ View full report in Codecov by Sentry. |
vegaro
approved these changes
Dec 5, 2023
| } | ||
| offeringIdentifier?.let { setOfferingId(offeringIdentifier) } | ||
| val (offeringId, fontProvider, _) = | ||
| PaywallViewAttributesReader.parseAttributes(context, attrs, R.styleable.PaywallFooterView) ?: return |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a possible approach to this comment. Basically, there is a bunch of duplicated logic between
PaywallViewandPaywallFooterView. This extracts part of it to a different class, the logic related to parsing xml attributes.We could try to create a superclass/interface that abstracts some of the other methods... But that is relatively straightforward, and didn't want to have to expose another type just for that.