Fix subscriber attributes JSON for old Android devices#144
Merged
Conversation
aboedo
approved these changes
May 19, 2020
Comment on lines
+109
to
+111
| val mapWithoutInnerMaps = mapValues { (_, value) -> | ||
| value.tryCast<Map<String, Any?>>(ifSuccess = { convert() }) | ||
| } |
Member
There was a problem hiding this comment.
❤️ kotlin functional programming.
Maybe we could leave a comment here explaining why this is needed, for future reference? So that a future dev doesn't come here, see this and say "wait, this isn't needed in modern android" and just kills the line
Member
Author
There was a problem hiding this comment.
lol, yeah good point, it took me a while to get this to work actually
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://stackoverflow.com/a/12155874
We are calling JSONObject(body) and body is Map<String, Map> so in Android < 19 we send this:
"attributes":"{$displayName={value=cesar, updated_at_ms=1589043738052}}"}
In Android >=19 we send it correctly:
{"attributes": {"$displayName": {"value": null, "updated_at_ms": 1589042480440}}}