[Do not merge] Paywalls: PoC of overriding fonts through the theme#1325
[Do not merge] Paywalls: PoC of overriding fonts through the theme#1325tonidero wants to merge 4 commits into
Conversation
There was a problem hiding this comment.
This might be a bit confusing... Basically the developer needs to override the specific styles we use within the paywall in order to use their typography everywhere, so maybe we should keep a list of these somewhere?
There was a problem hiding this comment.
we can make it a part of the API, like we did for iOS. So that if you want to use a custom font provider, it has to define what each of these (titleMedium, titleLarge, etc) is
There was a problem hiding this comment.
I was trying to avoid that since it means we need to override the theme for the paywall, instead of relying on the overall theme... but yeah, that might be the best way to make sure this can be customized. I will write up something so it can be part of the API.
e451f5f to
1cd491e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## paywalls #1325 +/- ##
=========================================
Coverage 84.53% 84.53%
=========================================
Files 194 194
Lines 6538 6538
Branches 952 952
=========================================
Hits 5527 5527
Misses 643 643
Partials 368 368 ☔ View full report in Codecov by Sentry. |
|
OMG that font 😂 |
There was a problem hiding this comment.
I think we should just keep this as the standard font for all paywalls
There was a problem hiding this comment.
🤣 I would totally do this, but we would need to find versions with smaller weights and cursive :P. That's not supported in this font unfortunately
There was a problem hiding this comment.
we can make it a part of the API, like we did for iOS. So that if you want to use a custom font provider, it has to define what each of these (titleMedium, titleLarge, etc) is
1cd491e to
d3c9f76
Compare
4766a65 to
c87433f
Compare
c87433f to
0ded173
Compare
There was a problem hiding this comment.
Note how by specifying the fontStyle to italic, this has more preference than the other font for italic, so we only use it there.
4976515 to
2900104
Compare
0ded173 to
f08ee07
Compare
2900104 to
fa8be70
Compare
f08ee07 to
ee4996d
Compare
|
Going to close this in favor of #1358 |
Description
This is a small PoC of how it looks like to override the fonts so they are used in the paywall:
