Trusted entitlements: Support signing static endpoints#1131
Merged
Conversation
tonidero
commented
Jul 10, 2023
| } | ||
|
|
||
| @Test | ||
| fun `can perform verified product entitlement mapping backend request`() { |
Contributor
Author
There was a problem hiding this comment.
These tests didn't exist in the base PR. I added them here for better coverage.
Contributor
Author
|
Backend integration tests are failing since the backend isn't returning a signature for static endpoints in the load shedder. |
Codecov Report
@@ Coverage Diff @@
## main #1131 +/- ##
==========================================
+ Coverage 85.30% 85.34% +0.03%
==========================================
Files 175 175
Lines 6099 6112 +13
Branches 893 902 +9
==========================================
+ Hits 5203 5216 +13
Misses 554 554
Partials 342 342
|
NachoSoto
approved these changes
Jul 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is based on #1119. Looks like the merge commit for that PR was lost in a rebase in the base PR #1117 😬.
This adds support for static endpoint signing. Currently, that would be the offerings and product-entitlement mapping endpoints.