Fix nospecializing Functions in Union{Nothing,Function} params (#59327)#251
Merged
NHDaly merged 1 commit intov1.10.2+RAIfrom Aug 26, 2025
Merged
Fix nospecializing Functions in Union{Nothing,Function} params (#59327)#251NHDaly merged 1 commit intov1.10.2+RAIfrom
Union{Nothing,Function} params (#59327)#251NHDaly merged 1 commit intov1.10.2+RAIfrom
Conversation
…iaLang#59327) Fixes JuliaLang#59326. Change the logic that decides not to specialize a function parameter based on whether or not the supplied argument is a Function, and that function is not used, so that it will still work if the SpecType is a Union{Function,Nothing} or any other union that contains a Function. The logic is changed from a hardcoded rule of `type_i == Function || type_i == Any || type_i == Base.Callable` to `type_i >: Function`. This covers all of the above cases, but also includes custom `Union{Function, T}` such as `Union{Function, Nothing}`. --------- Co-authored-by: Nick Robinson <npr251@gmail.com> Co-authored-by: Jameson Nash <vtjnash@gmail.com>
kpamnany
approved these changes
Aug 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
Backports JuliaLang#59327.
Original PR description:
Checklist
Requirements for merging:
Union{Nothing,Function}params JuliaLang/julia#59327port-to-*labels that don't apply.