staticdata: Accept CodeInstances with addl. code from pkgimages#236
Closed
kpamnany wants to merge 2 commits intov1.10.2+RAIfrom
Closed
staticdata: Accept CodeInstances with addl. code from pkgimages#236kpamnany wants to merge 2 commits intov1.10.2+RAIfrom
kpamnany wants to merge 2 commits intov1.10.2+RAIfrom
Conversation
1514949 to
591972f
Compare
3 tasks
These cannot be allowed to refer to 'copied' CodeInstances, or they will fail to be restored properly when loading pkgimages.
591972f to
1d56731
Compare
|
This PR is stale because it has been open 30 days with no activity. Comment or remove stale label, or this PR will be closed in 5 days. |
Author
|
We've decided not to use this fix due to stability concerns. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
This is a quick-fix for an issue where native code for inlineable method instances is not serialized to package images. We will need to switch to the proper fix for JuliaLang#58465, if one is added, but a proper fix will likely look quite different and only apply to 1.12+.
Checklist
Requirements for merging:
port-to-*labels that don't apply.