inference: apply tmerge limit elementwise to the Union (#50927)#214
Closed
kpamnany wants to merge 1 commit intov1.10.2+RAIfrom
Closed
inference: apply tmerge limit elementwise to the Union (#50927)#214kpamnany wants to merge 1 commit intov1.10.2+RAIfrom
kpamnany wants to merge 1 commit intov1.10.2+RAIfrom
Conversation
Author
|
Doesn't fix the failure. |
This allows forming larger unions, as long as each element in the Union
is both relatively distinct and relatively simple. For example:
tmerge(Base.BitSigned, Nothing) == Union{Nothing, Int128, Int16, Int32, Int64, Int8}
tmerge(Tuple{Base.BitSigned, Int}, Nothing) == Union{Nothing, Tuple{Any, Int64}}
tmerge(AbstractVector{Int}, Vector) == AbstractVector
Disables a test from dc8d885, which does not seem possible to handle currently.
This makes somewhat drastic changes to make this algorithm more
commutative and simpler, since we dropped the final widening to `Any`.
Co-authored-by: pchintalapudi <34727397+pchintalapudi@users.noreply.github.com>
Co-authored-by: Oscar Smith <oscardssmith@gmail.com>
541e83b to
f098f5c
Compare
|
This PR is stale because it has been open 30 days with no activity. Comment or remove stale label, or this PR will be closed in 5 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
This allows forming larger unions, as long as each element in the Union is both relatively distinct and relatively simple. For example:
Disables a test from dc8d885, which does not seem possible to handle currently.
This makes somewhat drastic changes to make this algorithm more commutative and simpler, since we dropped the final widening to
Any.Checklist
Requirements for merging:
port-to-*labels that don't apply.