Skip to content

fix(purity): treat new Date(arg) as pure, closes #1582#1677

Merged
Rel1cx merged 1 commit intomainfrom
fix/purity-rule-new-date-with-args
Mar 31, 2026
Merged

fix(purity): treat new Date(arg) as pure, closes #1582#1677
Rel1cx merged 1 commit intomainfrom
fix/purity-rule-new-date-with-args

Conversation

@Rel1cx
Copy link
Copy Markdown
Owner

@Rel1cx Rel1cx commented Mar 31, 2026

new Date(arg) with arguments is deterministic (pure), only new Date() without arguments is impure (depends on current time).

Update "[ ]" to "[x]" to check a box

What kind of change does this PR introduce?

Check at least one. If you are introducing a new binding, you must reference an issue where this binding has been proposed, discussed and approved by the maintainers.

  • Bugfix
  • Feature
  • Perf
  • Docs
  • Test
  • Chore
  • Enhancement
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

If yes, please describe the impact and migration path for existing applications in an attached issue.

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • I have added a convincing reason for adding this feature, if necessary

Other information

`new Date(arg)` with arguments is deterministic (pure),
only `new Date()` without arguments is impure (depends on current time).
@Rel1cx Rel1cx marked this pull request as ready for review March 31, 2026 19:35
@vercel
Copy link
Copy Markdown

vercel bot commented Mar 31, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
eslint-react Building Building Preview, Comment Mar 31, 2026 7:35pm

Request Review

@Rel1cx Rel1cx merged commit f727b59 into main Mar 31, 2026
10 of 11 checks passed
@Rel1cx Rel1cx deleted the fix/purity-rule-new-date-with-args branch March 31, 2026 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant