Conversation
Cover the following changes introduced in PR #1660: - find-import-source: circular reference guard with visited Set - is-react-api: correct suffix matching with endsWith - component-detection-legacy: isRenderMethodLike covers ClassExpression, isClassComponent with optional context, isThisSetState -> isThisSetStateCall - hook-is: isHook -> isHookDefinition rename, isHookCallWithName un-exported Cover the following changes introduced in PR #1662: - function-init-path: support ClassExpression in addition to ClassDeclaration - node-equality: handle JSXNamespacedName in JSXAttribute comparison New test files: - packages/core/src/api/find-import-source.test.ts (6 tests) - packages/core/src/api/is-react-api.test.ts (32 tests) - packages/core/src/component/component-detection-legacy.test.ts (13 tests) - packages/core/src/hook/hook-is.test.ts (20 tests) - packages/utilities/ast/src/function-init-path.test.ts (6 tests) - packages/utilities/ast/src/node-equality.test.ts (16 tests)
…n cases to isNodeEqual PR #1662 changed JSXAttribute name comparison from direct string comparison to recursive isNodeEqual(a.name, b.name), but did not add handling for JSX name node types. This caused JSXAttribute structural equality to always return false for non-reference-equal nodes, as JSXIdentifier / JSXNamespacedName / JSXMemberExpression all fell through to the default case.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___)Other information