Skip to content

fix(eslint-plugin-react-jsx): improve type safety and edge case handling#1664

Merged
Rel1cx merged 1 commit intomainfrom
fix/jsx-plugin-improvements
Mar 30, 2026
Merged

fix(eslint-plugin-react-jsx): improve type safety and edge case handling#1664
Rel1cx merged 1 commit intomainfrom
fix/jsx-plugin-improvements

Conversation

@Rel1cx
Copy link
Copy Markdown
Owner

@Rel1cx Rel1cx commented Mar 30, 2026

  • no-deoptimization: Add type guard for JSXIdentifier to properly handle namespaced attributes like xml:key
  • utils/jsx: Add null check for closer in getChildrenSourceText to handle malformed JSX gracefully
  • Add test cases for URL-like text and namespace attributes

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Perf
  • Docs
  • Test
  • Chore
  • Enhancement
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • I have added a convincing reason for adding this feature, if necessary

Other information

- no-deoptimization: Add type guard for JSXIdentifier to properly handle
  namespaced attributes like xml:key
- utils/jsx: Add null check for closer in getChildrenSourceText to handle
  malformed JSX gracefully
- Add test cases for URL-like text and namespace attributes
@vercel
Copy link
Copy Markdown

vercel bot commented Mar 30, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
eslint-react Ready Ready Preview, Comment Mar 30, 2026 8:56am

Request Review

@Rel1cx Rel1cx marked this pull request as ready for review March 30, 2026 08:56
@Rel1cx Rel1cx merged commit ed34c77 into main Mar 30, 2026
10 of 11 checks passed
@Rel1cx Rel1cx deleted the fix/jsx-plugin-improvements branch March 30, 2026 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant