Skip to content

Fixed search phrase for determining the amount of successful tests#954

Merged
langou merged 1 commit intoReference-LAPACK:masterfrom
ACSimon33:lapack_testing_python_summary_bug
Dec 1, 2023
Merged

Fixed search phrase for determining the amount of successful tests#954
langou merged 1 commit intoReference-LAPACK:masterfrom
ACSimon33:lapack_testing_python_summary_bug

Conversation

@ACSimon33
Copy link
Copy Markdown
Contributor

Description

In the lapack_testing.py script we search for run) to determine the amount of succesful tests:

if (line.find("run")!=-1):
    whereisrun=words_in_line.index("run)")

The problem is that in the if clause we only looked for run which can match other things like for example "truncated QR". That means if the truncated QR routine fails, the test summary will fail as well with the following message:

ValueError: 'run)' is not in list

Checklist

  • [n/a] The documentation has been updated.
  • [n/a] If the PR solves a specific issue, it is set to be closed on merge.

@langou
Copy link
Copy Markdown
Contributor

langou commented Dec 1, 2023

Great catch and elegant fix. Thanks!

@langou langou merged commit a4298d5 into Reference-LAPACK:master Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants