Reduce number of macros in fortran compilation line for BLAS _64 API#861
Merged
langou merged 1 commit intoReference-LAPACK:masterfrom Jul 4, 2023
Merged
Reduce number of macros in fortran compilation line for BLAS _64 API#861langou merged 1 commit intoReference-LAPACK:masterfrom
langou merged 1 commit intoReference-LAPACK:masterfrom
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #861 +/- ##
=======================================
Coverage 0.00% 0.00%
=======================================
Files 1916 1916
Lines 188485 188485
=======================================
Misses 188485 188485 ☔ View full report in Codecov by Sentry. |
langou
approved these changes
Jun 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The PR removes the problem with very long list of
... -DISAMAX=ISAMAX_64 -DSASUM=SASUM_64 -DSAXPY=SAXPY_64 -D...options in BLAS_64 compilation lines. This PR adds only required macros for each particular file instead of generating list of macros for all files.Compilation line before:
Compilation line after:
Minor changes:
fPICwithPOSITION_INDEPENDENT_CODEproperty in BLAS CMake configChecklist