Fix scaling in (S/D)TGSNA, fix #103, thanks to @elivanova#830
Merged
langou merged 1 commit intoReference-LAPACK:masterfrom May 24, 2023
Merged
Fix scaling in (S/D)TGSNA, fix #103, thanks to @elivanova#830langou merged 1 commit intoReference-LAPACK:masterfrom
langou merged 1 commit intoReference-LAPACK:masterfrom
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #830 +/- ##
========================================
Coverage 0.00% 0.00%
========================================
Files 1908 1908
Lines 187072 186958 -114
========================================
+ Misses 187072 186958 -114
☔ View full report in Codecov by Sentry. |
martin-frbg
approved these changes
May 24, 2023
Collaborator
martin-frbg
left a comment
There was a problem hiding this comment.
Again, may I suggest editing the PR title to something like "Fix scaling in (S/D)TGSNA" instead of "Fix 103" ?
Contributor
Done. Thanks for the suggestion. |
langou
approved these changes
May 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #103.
This PR addresses an old issue using the solution presented by @elivanova in #103 (comment).