Skip to content

fix rfp test for DIAG = U#796

Merged
langou merged 1 commit intoReference-LAPACK:masterfrom
dklyuchinskiy:678-fix-test-rfp
Feb 14, 2023
Merged

fix rfp test for DIAG = U#796
langou merged 1 commit intoReference-LAPACK:masterfrom
dklyuchinskiy:678-fix-test-rfp

Conversation

@dklyuchinskiy
Copy link
Copy Markdown
Contributor

@dklyuchinskiy dklyuchinskiy commented Feb 14, 2023

Fix, provided by @AlexanderZotkevich in #678 and code style alignement.

@dklyuchinskiy dklyuchinskiy changed the title fix rfp test fix rfp test for DIAG = 'U' Feb 14, 2023
@dklyuchinskiy dklyuchinskiy changed the title fix rfp test for DIAG = 'U' fix rfp test for DIAG = U Feb 14, 2023
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 14, 2023

Codecov Report

Base: 0.00% // Head: 0.00% // No change to project coverage 👍

Coverage data is based on head (6b51f66) compared to base (b1e25a3).
Patch has no changes to coverable lines.

❗ Current head 6b51f66 differs from pull request most recent head 5fd6d64. Consider uploading reports for the commit 5fd6d64 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #796   +/-   ##
=======================================
  Coverage    0.00%    0.00%           
=======================================
  Files        1908     1908           
  Lines      187072   187072           
=======================================
  Misses     187072   187072

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@AlexanderZotkevich
Copy link
Copy Markdown

AlexanderZotkevich commented Feb 14, 2023

It's OK from my side. Thanks @dklyuchinskiy !

langou
langou approved these changes Feb 14, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@langou langou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Long overdue. Very thankful for you pointing this out in June 2022 and for proposing a PR right now. This is helpful.

@langou langou merged commit eb8f5fa into Reference-LAPACK:master Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@langou langou langou approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dklyuchinskiy @AlexanderZotkevich @langou