Fix Y misscale in GEMV for some cases#787
Closed
bE554357 wants to merge 1 commit intoReference-LAPACK:masterfrom
Closed
Fix Y misscale in GEMV for some cases#787bE554357 wants to merge 1 commit intoReference-LAPACK:masterfrom
bE554357 wants to merge 1 commit intoReference-LAPACK:masterfrom
Conversation
Contributor
|
Hi, Note that the code follows the convention as written in the article
I quote (page 5, section 3 - naming convention)
Cheers, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
According to the description,$M$ or $N$ could be zero. It is expected that the vector $\mathbf{y}$ will be correctly scaled by scalar for such cases.
For example, let GEMV computes
$\mathbf{y} := 0 \cdot \mathbf{y} + \mathbf{A}\mathbf{x}$ $\mathbf{x}$ is zero length vector. It is expected, that $\mathbf{y} = 0$ after GEMV, but it is not scaled due to statement in implementation:
and
This pull request is objected to fix the behavior in such cases.