Fix uninitialized out variables in *LARR* functions#775
Merged
langou merged 1 commit intoReference-LAPACK:masterfrom Dec 19, 2022
Merged
Fix uninitialized out variables in *LARR* functions#775langou merged 1 commit intoReference-LAPACK:masterfrom
langou merged 1 commit intoReference-LAPACK:masterfrom
Conversation
akobotov
approved these changes
Dec 14, 2022
martin-frbg
approved these changes
Dec 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up on #770. Thanks to @akobotov for spotting a couple more similar issues.
I added initialization for all integer scalar outputs but there are some places when double scalar outputs are left uninitialized after quick return, here is the list (listing double precision only):
WL,WUPIVMINSIGMAW,WERRThey describe some characteristics of the resulting computation. For example
WL,WUdescribe the range of output eigenvalues. But quick return implies no computation and no eigenvalues. So it might be fine to keep them uninitialized but I would like to hear feedback from others. Please let me know if you think those should be initialized too, I'll extend the PR.