Merged
Conversation
Contributor
|
Thanks @ACSimon33. Good that the windows compiled is more picky on this EXTERNAL than others. Thanks for the two fixes. |
langou
approved these changes
Nov 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I encountered a build failure on Windows due to a missing symbol
DGESVQwhich doesn't exist. It was a typo in the test framework and should beDGESVDQ.Also, I removed some unnecessary return statements in the trapezoidal transposition functions which I introduced by mistake in #742.