Skip to content

NaN check for trapezoidal routines.#738

Merged
langou merged 5 commits intoReference-LAPACK:masterfrom
ACSimon33:LAPACKE_norm_routines
Oct 27, 2022
Merged

NaN check for trapezoidal routines.#738
langou merged 5 commits intoReference-LAPACK:masterfrom
ACSimon33:LAPACKE_norm_routines

Conversation

@ACSimon33
Copy link
Copy Markdown
Contributor

@ACSimon33 ACSimon33 commented Oct 27, 2022

Description

Following up on #737 I've implemented a NaN check for trapezoidal matrices. I've added adirect argument to support a whole bunch of trapezoidal matrices (e.g. those which occur in xLARFB):

Diagonals 'F' (front / forward) and 'B' (back / backward):

        A = ( F       )           A = ( F     B       )
            (    F    )               (    F     B    )
            ( B     F )               (       F     B )
            (    B    )
            (       B )

      direct = 'F', uplo = 'L':

        A = ( *       )           A = ( *             )
            ( *  *    )               ( *  *          )
            ( *  *  * )               ( *  *  *       )
            ( *  *  * )
            ( *  *  * )

      direct = 'F', uplo = 'U':

        A = ( *  *  * )           A = ( *  *  *  *  * )
            (    *  * )               (    *  *  *  * )
            (       * )               (       *  *  * )
            (         )
            (         )

      direct = 'B', uplo = 'L':

        A = (         )           A = ( *  *  *       )
            (         )               ( *  *  *  *    )
            ( *       )               ( *  *  *  *  * )
            ( *  *    )
            ( *  *  * )

      direct = 'B', uplo = 'U':

        A = ( *  *  * )           A = (       *  *  * )
            ( *  *  * )               (          *  * )
            ( *  *  * )               (             * )
            (    *  * )
            (       * )

For now, I've only applied the new NaN check to LAPACKE_?lantr. But the NaN check is designed to also work for LAPACKE_?larfb and potential other routines. @langou I'll investigate those later since I want first confirm with you that the interface that I've chosen is alright.

Additionally, I fixed some missing symbols in the Makefile which I forgot to add in my last PR for #722.

Checklist

@langou
Copy link
Copy Markdown
Contributor

langou commented Oct 27, 2022

Thanks @ACSimon33. This is great. I like the pictures of the matrices occurring in LARFB, very nicely done.

@langou langou merged commit 17f99f2 into Reference-LAPACK:master Oct 27, 2022
@ACSimon33 ACSimon33 deleted the LAPACKE_norm_routines branch October 28, 2022 07:31
@ACSimon33 ACSimon33 mentioned this pull request Oct 30, 2022
Merged
@julielangou julielangou added this to the LAPACK 3.11.0 milestone Nov 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@langou langou langou approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

LAPACK 3.11.0

Development

Successfully merging this pull request may close these issues.

NaN check in LAPACKE_?lantr isn't correct for m != n

4 participants

@ACSimon33 @langou @julielangou @STCE2023