Fix line lengths for the extended API#1079
Merged
langou merged 9 commits intoReference-LAPACK:masterfrom Dec 3, 2024
Merged
Conversation
For the extended API subroutine names are extended with _64 (e.g. CGEGS becomes CGEGS_64). Extra space is needed so that the extension does not violate Fortran line length conventions.
langou
approved these changes
Nov 29, 2024
Contributor
|
Hi @hjjvandam, thanks for all the edits. I am in favor of merging. Julien. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Spack software stack management system builds LAPACK with the extended API. Using Spack to build the development version of LAPACK causes problems when the subroutine names are extended by appending "_64". In a number of cases the 3 extra characters push the line length over 72 characters, causing the compiler to truncate the code, and generate errors.
Most of the instances I have hit are in deprecated subroutines. Nevertheless, Spack insists on building deprecated subroutines as many software packages don't actively track what code has been deprecated. Therefore leaving those subroutines out would cause many builds to fail.
I have gone through every subroutine that failed to compile with the extended subroutine names and fixed the line lengths to ensure that even with the extended subroutine names the line lengths remain below 72 characters.
Just to be sure I have also run the test cases (source code truncation can lead to syntactically valid but semantically different Fortran). The output of the tests is
Checklist