Fix lto type mismatch#1027
Merged
langou merged 6 commits intoReference-LAPACK:masterfrom Jun 20, 2024
Merged
Conversation
…ed before including cblas_64.h
…x arrays were declared as float* or double* instead of void*.
Contributor
Author
|
@martin-frbg If this is accepted, we probably could take a look at OpenMathLib/OpenBLAS#4128 again |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1027 +/- ##
=======================================
Coverage 0.00% 0.00%
=======================================
Files 1933 1933
Lines 190594 190594
=======================================
Misses 190594 190594 ☔ View full report in Codecov by Sentry. |
langou
approved these changes
Jun 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There were several issues flagged by GCC when using LTO. The things I fixed are the following:
cblas_f77.hheader contained some wrong declarations, where complex arguments had types likefloat*ordouble*instead ofvoid*LAPACK_lsamedeclaration had 4 STRLEN arguments instead of the necessary 2I compiled with
-Werror=lto-type-mismatchand it seems all issues are resolved.We could enable LTO in the CI pipelines (CMake:
-DCMAKE_INTERPROCEDURAL_OPTIMIZATION=ON) and add the-Werror=lto-type-mismatchflag as well now.Fixes #334
Fixes #990
Checklist