MOD-12014 Always enable thread-safe cache for async flush support (#1446) #1449
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 7211a07)
…xistent $crate function - Changed $crate::init_ijson_shared_string_cache to ijson::init_shared_string_cache - Added ijson import to macro context - Removed unused RedisValue import
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 8.0 #1449 +/- ##
==========================================
- Coverage 79.24% 79.23% -0.01%
==========================================
Files 15 15
Lines 3729 3723 -6
==========================================
- Hits 2955 2950 -5
+ Misses 774 773 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ephraimfeldblum
approved these changes
Nov 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit 7211a07)
Note
Always enable the thread-safe shared string cache in
redis_jsoninitialization and remove config-based detection.redis_json/src/lib.rs):ijson::init_shared_string_cache(true)and log accordingly.CONFIG GET bigredis-enabledcheck and related logic; drop dependency onRedisValuein this path.use ijson;import to support the new initialization path.Written by Cursor Bugbot for commit 0bf655f. This will update automatically on new commits. Configure here.