Skip to content

MOD-9169 Do not double count used capacity of containers in memory st… #1330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ephraimfeldblum merged 1 commit into from
Mar 26, 2025
Merged

MOD-9169 Do not double count used capacity of containers in memory st… #1330

ephraimfeldblum merged 1 commit into from
Mar 26, 2025

Conversation

@ephraimfeldblum
Copy link
Collaborator

@ephraimfeldblum ephraimfeldblum commented Mar 25, 2025

…ats (#1329)

  • do not double count used capacity of containers in memory stats

  • unit test

  • flow tests

  • separate root from recursive calls

  • rustic

(cherry picked from commit e75f9af)

@ephraimfeldblum
MOD-9169 Do not double count used capacity of containers in memory st…
4b243df 
…ats (#1329)

* do not double count used capacity of containers in memory stats

* unit test

* flow tests

* separate root from recursive calls

* rustic

(cherry picked from commit e75f9af)
@codecov
Copy link

codecov bot commented Mar 25, 2025

Codecov Report

Attention: Patch coverage is 88.46154% with 3 lines in your changes missing coverage. Please review.

Please upload report for BASE (8.0@25dd29f). Learn more about missing BASE report.

Files with missing lines Patch % Lines
redis_json/src/ivalue_manager.rs 88.46% 3 Missing ⚠️
Additional details and impacted files 
@@          Coverage Diff           @@
##             8.0    #1330   +/-   ##
======================================
  Coverage       ?   78.10%           
======================================
  Files          ?       15           
  Lines          ?     3868           
  Branches       ?        0           
======================================
  Hits           ?     3021           
  Misses         ?      847           
  Partials       ?        0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ephraimfeldblum ephraimfeldblum merged commit 6bd6262 into 8.0 Mar 26, 2025
17 checks passed
@ephraimfeldblum ephraimfeldblum deleted the ephraim_backport-1329-to-8.0 branch March 26, 2025 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eranhd eranhd eranhd approved these changes

@MeirShpilraien MeirShpilraien Awaiting requested review from MeirShpilraien

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ephraimfeldblum @eranhd