Skip to content

added tls support#32

Merged
MeirShpilraien merged 7 commits intomasterfrom
tls_support
Mar 14, 2022
Merged

added tls support#32
MeirShpilraien merged 7 commits intomasterfrom
tls_support

Conversation

@MeirShpilraien
Copy link

No description provided.

@MeirShpilraien MeirShpilraien mentioned this pull request Feb 27, 2022
Closed
Copy link
Contributor

@chayim chayim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes below. Also, You might want to look at adding click-option-groups in order to make the code more maintainable. WDYT?

@MeirShpilraien
Copy link
Author

Changes below. Also, You might want to look at adding click-option-groups in order to make the code more maintainable. WDYT?

Its not that popular repository, are we sure we want to use it?

@MeirShpilraien MeirShpilraien requested a review from chayim March 10, 2022 09:46
@MeirShpilraien MeirShpilraien merged commit c0908b9 into master Mar 14, 2022
@MeirShpilraien MeirShpilraien deleted the tls_support branch March 14, 2022 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants