[MOD-13847] Don't error if a numeric index hasn't been initialized yet#8460
Merged
LukeMathWalker merged 1 commit intomasterfrom Feb 25, 2026
Merged
[MOD-13847] Don't error if a numeric index hasn't been initialized yet#8460LukeMathWalker merged 1 commit intomasterfrom
LukeMathWalker merged 1 commit intomasterfrom
Conversation
🛡️ Jit Security Scan Results
✅ No security findings were detected in this PR
Security scan by Jit
|
4 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #8460 +/- ##
=======================================
Coverage 82.51% 82.52%
=======================================
Files 421 421
Lines 60938 60948 +10
Branches 18808 18818 +10
=======================================
+ Hits 50284 50298 +14
+ Misses 10463 10459 -4
Partials 191 191
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
7b89449 to
2f85461
Compare
|
meiravgri
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the changes in the pull request
In #8305, I thought I could get away with returning an error for a numeric index that hadn't been initialised yet, but unfortunately it won't fly.
Creating numeric indexes eagerly would result in increased memory usage, and returning an error after the user has correctly issued a
CREATE INDEXcommand would be confusing.So, back to the original: return an empty response with the proper keys. I structured the code to minimise the risk of divergence between empty and non-empty keys, with tests to ensure they have the correct structure.
Which additional issues this PR fixes
Main objects this PR modified
Mark if applicable
Release Notes
If a release note is required (bug fix / new feature / enhancement), describe the user impact of this PR in the title.
Note
Low Risk
Small, localized change to debug/diagnostics output handling; main risk is subtle response-format regressions, covered by added snapshot tests.
Overview
Fixes FT.DEBUG numeric index introspection to gracefully handle uninitialized numeric indexes.
The Rust debug helpers (
debug_summary,debug_dump_index,debug_dump_tree) now acceptOption<&NumericRangeTree>and return zero/empty responses when absent, while the C/Rust FFI wrappers and generated header docs explicitly allowt == NULLinstead of asserting. Integration snapshots add coverage for theNonecase and verify the empty responses keep the same key structure as the default tree outputs.Written by Cursor Bugbot for commit 2f85461. This will update automatically on new commits. Configure here.