[MOD-14058] Fork the slab crate#8407
Merged
LukeMathWalker merged 1 commit intomasterfrom Feb 17, 2026
Merged
Conversation
c583d61 to
cb2c342
Compare
cb2c342 to
c5d4a50
Compare
|
gdesmott
approved these changes
Feb 17, 2026
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #8407 +/- ##
==========================================
- Coverage 82.87% 82.85% -0.03%
==========================================
Files 414 416 +2
Lines 58819 59342 +523
Branches 16873 17398 +525
==========================================
+ Hits 48746 49166 +420
- Misses 9892 9993 +101
- Partials 181 183 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the changes in the pull request
As a first step in building up a generational node arena, we need to fork the
slabcrate.The only changes in this PR are the following:
// SAFETYcommentsgenerational_slabin preparationmem_usagemethod fromnumeric_range_treetogenerational_slabWhich additional issues this PR fixes
Main objects this PR modified
Mark if applicable
Release Notes
If a release note is required (bug fix / new feature / enhancement), describe the user impact of this PR in the title.
Note
Medium Risk
Adds and adopts a forked core container with
unsafeinternals, and changes memory-usage accounting used bynumeric_range_tree, which could impact correctness/perf if the fork diverges from upstream behavior.Overview
Introduces a new in-workspace crate,
generational_slab, by forkingslab(nowno_std-capable, with optionalserdesupport) and adds a comprehensive test suite.Updates the workspace to depend on
generational_slabinstead of the externalslabcrate, and migratesnumeric_range_tree’s arena to use it;mem_usagecalculation is moved fromnumeric_range_tree’s manual estimate toSlab::mem_usage(), and several arena/treemem_usage/len/capacityaccessors are madeconst.Tooling is updated to treat
generational_slabas a forked crate for license-header linting, and build metadata (Cargo.lock, codespell ignore list) is adjusted accordingly.Written by Cursor Bugbot for commit c5d4a50. This will update automatically on new commits. Configure here.