Conversation
2 tasks
|
Hi, I’m Jit, a friendly security platform designed to help developers build secure applications from day zero with an MVS (Minimal viable security) mindset. In case there are security findings, they will be communicated to you as a comment inside the PR. Hope you’ll enjoy using Jit. Questions? Comments? Want to learn more? Get in touch with us. |
Contributor
🛡️ Jit Security Scan Results
✅ No security findings were detected in this PR
Security scan by Jit
|
Contributor
Automated performance analysis summaryThis comment was automatically generated given there is performance data available. In summary:
You can check a comparison in detail via the grafana link ## DetailsTests with No Significant Changes (30 tests)Tests with No Significant Changes
|
Contributor
Automated performance analysis summaryThis comment was automatically generated given there is performance data available. In summary:
You can check a comparison in detail via the grafana link Performance Regressions and Issues - Comparison between master and gd_lto_ci.Time Period from a month ago. (environment used: oss-standalone)
Tests with No Significant Changes (35 tests)Tests with No Significant Changes
|
That's the version currently required to build with LTO. Also: move llvm version to its own file so we can have the version in a single place.
memark
reviewed
Mar 16, 2026
memark
previously approved these changes
Mar 16, 2026
Collaborator
Maybe we could rename the PR to reflect this before merging? |
.github/workflows/task-test.yml
Outdated
| LOG: 1 | ||
| CLEAR_LOGS: 0 | ||
| ENABLE_ASSERT: 1 | ||
| LTO: ${{ needs.get-config.outputs.enable_lto }} |
Collaborator
There was a problem hiding this comment.
We don't want LTO on coverage/sanitize tasks.
Collaborator
Author
There was a problem hiding this comment.
Fixed.
But I don't remember why not?
Collaborator
There was a problem hiding this comment.
For coverage, the fewer optimisations you have, the better the report (as a rule of thumb).
For sanitiser, it's complex/slow enough as is, I'd prefer to avoid adding yet another source of build complexity there. But I could be convinced otherwise.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
That's the only platform with a new enough toolchain for now.
LukeMathWalker
approved these changes
Mar 16, 2026
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #8092 +/- ##
==========================================
- Coverage 82.39% 82.35% -0.05%
==========================================
Files 449 449
Lines 62470 62501 +31
Branches 19805 19805
==========================================
Hits 51471 51471
- Misses 10805 10836 +31
Partials 194 194
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable LTO in the CI:
Mark if applicable
Release Notes
Note
Medium Risk
Medium risk because it changes CI build flags and LLVM toolchain installation/versioning, which can affect build determinism and introduce platform-specific failures.
Overview
Enables Link Time Optimization (LTO) in CI for
ubuntu:nobleby extendingtask-get-config.ymlwith anenable_ltooutput and setting it to1for Noble on bothx86_64andaarch64.Updates
task-test.ymlto exportLTO=1only when the platform enables it, and automatically disables LTO for sanitizer and coverage runs.Introduces centralized LLVM versioning via
.install/LLVM_VERSION.sh(set to 21), updates.install/install_llvm.shto use that version on Linux while pinning macOS to LLVM 18, and ensures Ubuntu 24.04 setup installs LLVM (ubuntu_24.04.shcallsinstall_llvm.sh).Written by Cursor Bugbot for commit 793bf88. This will update automatically on new commits. Configure here.