[2.8] [MOD-12414] Add Internal cursor reads metric to cluster FT.PROFILE output #7751
Merged
[2.8] [MOD-12414] Add Internal cursor reads metric to cluster FT.PROFILE output #7751
Internal cursor reads metric to cluster FT.PROFILE output #7751Conversation
[MOD-12414] Add `Internal cursor reads` metric to cluster FT.PROFILE output (#7709) * add cursor_reads to req struct update in runCursor print in Profile_Print if cursor * Fix: Preserve timeout flag across cursor reads in cluster FT.PROFILE Use |= instead of = to ensure has_timedout remains true once set, preventing earlier cursor read warnings from being lost in final output. * fix test * fix test * add message to the test (cherry picked from commit 005186a)
Internal cursor reads metric to cluster FT.PROFILE output (Internal cursor reads metric to cluster FT.PROFILE output
…ROFILE output (#7746) * [MOD-12414] Add `Internal cursor reads` metric to cluster FT.PROFILE output (#7709) * add cursor_reads to req struct update in runCursor print in Profile_Print if cursor * Fix: Preserve timeout flag across cursor reads in cluster FT.PROFILE Use |= instead of = to ensure has_timedout remains true once set, preventing earlier cursor read warnings from being lost in final output. * fix test * fix test * add message to the test (cherry picked from commit 005186a) * fix test * fix test * fix test (cherry picked from commit 1911f5b)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 2.8 #7751 +/- ##
==========================================
- Coverage 87.63% 87.60% -0.04%
==========================================
Files 203 203
Lines 35215 35227 +12
==========================================
- Hits 30862 30860 -2
- Misses 4353 4367 +14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
GuyAv46
approved these changes
Dec 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport #7709 to
2.8Note
Expose per-shard cursor read count in FT.PROFILE AGGREGATE and track cumulative timeout state across multiple cursor reads, with tests.
size_t cursor_readstoAREQand increment it inrunCursor(); expose in profile asInternal cursor readswhenQEXEC_F_IS_CURSOR.req->has_timedout = ...toreq->has_timedout |= ...and pass the accumulated value to profile printer."Internal cursor reads"toprofilemap for cursor requests.['Internal cursor reads', <count>]array in profile for cursor requests.Internal cursor readsexists and equals expected counts in shard profiles forFT.PROFILE ... AGGREGATE(RESP2/RESP3, cluster).test_MOD_7454union profile parsing to match updated response structure.Written by Cursor Bugbot for commit 5b6f740. This will update automatically on new commits. Configure here.