[8.4] [MOD-12414] Add Internal cursor reads metric to cluster FT.PROFILE output (#7709)#7736
Merged
[8.4] [MOD-12414] Add Internal cursor reads metric to cluster FT.PROFILE output (#7709)#7736
Internal cursor reads metric to cluster FT.PROFILE output (#7709)#7736Conversation
…output (#7709) * add cursor_reads to req struct update in runCursor print in Profile_Print if cursor * Fix: Preserve timeout flag across cursor reads in cluster FT.PROFILE Use |= instead of = to ensure has_timedout remains true once set, preventing earlier cursor read warnings from being lost in final output. * fix test * fix test * add message to the test (cherry picked from commit 005186a)
GuyAv46
approved these changes
Dec 10, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 8.4 #7736 +/- ##
==========================================
- Coverage 85.96% 85.94% -0.02%
==========================================
Files 331 331
Lines 52954 52960 +6
Branches 11998 11998
==========================================
- Hits 45524 45519 -5
- Misses 7263 7274 +11
Partials 167 167
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport #7709 to 8.4
Note
Expose per-shard "Internal cursor reads" in FT.PROFILE AGGREGATE and persist timeout state across cursor reads, with comprehensive RESP2/RESP3 tests.
AREQ.cursor_readsto track number of internal cursor reads; increment inrunCursor."Internal cursor reads"in profile output for cursor-based (internal) requests (src/profile.c).req->has_timedout |= has_timedoutand use it inProfilePrinterCtx.Internal cursor readspresence/count for AGGREGATE under RESP2/RESP3, including timeout scenarios."Internal cursor reads"in shard profiles.Written by Cursor Bugbot for commit 08cf027. This will update automatically on new commits. Configure here.