[2.8] [MOD-12320] [MOD-12625] Ensure full profile output on timeout with RETURN policy#7480
Merged
[2.8] [MOD-12320] [MOD-12625] Ensure full profile output on timeout with RETURN policy#7480
Conversation
…policy (#7472) * not backported yet: aggregate_exec.c dist_aggregate.c test_profile.py * introduce forProfiling in MRCommand * rewrite sendChunk_ReplyOnly_EmptyResults with a dummy result rewrite: printAggProfile getNextReply frees the reply so no need to free it add test * wrap dummy result in isProfile * fix return early * consume current result * add test to partially consumed (cherry picked from commit 3d4e635)
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.8 #7480 +/- ##
==========================================
- Coverage 87.50% 87.47% -0.03%
==========================================
Files 203 203
Lines 34812 34918 +106
==========================================
+ Hits 30461 30546 +85
- Misses 4351 4372 +21
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
GuyAv46
approved these changes
Nov 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #7345 (MOD-12320) and #7472 (MOD-12625) to 2.8
Note
Ensures complete profile output on timeouts (RETURN policy) by tracking profiling state, draining pending shard replies, and adding FT.CURSOR PROFILE; updates command/iterator APIs and tests.
MRCommand.forProfilingflag and new root commandC_PROFILE; propagate through command copy and cursor flow.CURSOR PROFILEon next dispatch.getCursorCommandto send_FT.CURSOR PROFILEwhen timed out on profile queries; preserve flags.MRIterator_GetChannelSizeandMRIterator_GetNumShards.printAggProfile, collect profile info from current and remaining channel replies; drain channel until empty; warn if partial shard profiles.AREQ.has_timedoutand pass inProfilePrinterCtxconsistently.FT.CURSOR PROFILE {index} {cid}to return profile (with empty/dummy results) and free the cursor; errors for missing/non-profile cursors.sendChunk_ReplyOnly_EmptyResultsto emit profile without results (RESP2/RESP3, cursor/non-cursor).Written by Cursor Bugbot for commit 100c4b9. This will update automatically on new commits. Configure here.