[2.8] Improve timeout check for FT.AGGREGATE in cluster mode - [MOD-12434]#7393
Merged
redisearch-backport-pull-request[bot] merged 1 commit into2.8from Nov 17, 2025
Merged
Conversation
2 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 2.8 #7393 +/- ##
==========================================
- Coverage 87.48% 87.45% -0.03%
==========================================
Files 203 203
Lines 34782 34784 +2
==========================================
- Hits 30428 30420 -8
- Misses 4354 4364 +10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
GuyAv46
approved these changes
Nov 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport of #7359 to
2.8.Note
Adjust shard reply handling to accept results with minimal lengths, add RESP2/RESP3-specific empty-reply detection, and downgrade empty-reply logging to verbose.
coord/src/dist_aggregate.c)map["results"]is an array regardless of length (removed >0 check).MRReply_Length(results) >= 1(was >1).getNextReply(RESP3:resultslength == 0;RESP2: rows length == 1), discard such replies, and log at verbose instead of warning.Written by Cursor Bugbot for commit 071f3f1. This will update automatically on new commits. Configure here.