Skip to content

[2.8] [MOD-11011] Fix deadlock while RDB loading and RM_Yield (#6763)#6784

Merged
JoanFM merged 11 commits into2.8from
backport-6763-to-2.8
Sep 7, 2025
Merged

[2.8] [MOD-11011] Fix deadlock while RDB loading and RM_Yield (#6763)#6784
JoanFM merged 11 commits into2.8from
backport-6763-to-2.8

Conversation

@JoanFM
Copy link
Copy Markdown
Collaborator

@JoanFM JoanFM commented Sep 5, 2025

No description provided.

* add test file trying to reproduce lock

* test RDB update

* try the test changes

* only keep test changes

* remove some logs

* fix: Yield to Redis before acquiring Write Lock

* proper Lock initialization on RDB load

* proper initialization

* remove test file

* remove comment from code

* add numOps instead of reducing Yield frequency

* move lock init

* add DEBUG command to improve testing

* fix failing tests

* remove added tests by mistake

(cherry picked from commit 4710f44)
@JoanFM JoanFM changed the title [MOD-11011] Backport PR-6763 to 2.8 [2.8] - [MOD-11011] Backport PR-6763 to 2.8 Sep 5, 2025
@JoanFM JoanFM changed the base branch from master to 2.8 September 5, 2025 08:18
@JoanFM JoanFM changed the title [2.8] - [MOD-11011] Backport PR-6763 to 2.8 [2.8] [MOD-11011] Fix deadlock while RDB loading and RM_Yield (#6763) Sep 5, 2025
@JoanFM JoanFM force-pushed the backport-6763-to-2.8 branch 2 times, most recently from 008e12e to da76f70 Compare September 5, 2025 11:36
@JoanFM JoanFM force-pushed the backport-6763-to-2.8 branch from da76f70 to 26e13f3 Compare September 5, 2025 11:55
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 5, 2025

Codecov Report

❌ Patch coverage is 89.18919% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.49%. Comparing base (96fc89e) to head (129e2b0).
⚠️ Report is 1 commits behind head on 2.8.

Files with missing lines Patch % Lines
src/debug_commands.c 81.81% 2 Missing ⚠️
src/info/indexes_info.c 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              2.8    #6784      +/-   ##
==========================================
- Coverage   87.50%   87.49%   -0.02%     
==========================================
  Files         203      203              
  Lines       35611    35634      +23     
==========================================
+ Hits        31162    31178      +16     
- Misses       4449     4456       +7     
Flag Coverage Δ
flow 81.81% <89.18%> (-0.22%) ⬇️
unit 42.75% <40.54%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JoanFM JoanFM added this pull request to the merge queue Sep 7, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 7, 2025
@JoanFM JoanFM added this pull request to the merge queue Sep 7, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 7, 2025
@JoanFM JoanFM added this pull request to the merge queue Sep 7, 2025
Merged via the queue into 2.8 with commit 8733a06 Sep 7, 2025
11 checks passed
@JoanFM JoanFM deleted the backport-6763-to-2.8 branch September 7, 2025 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants