[2.8] MOD-10975: Fix fd leak when OOM (#6672)#6703
Merged
Conversation
(cherry picked from commit 56f6f0e)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 2.8 #6703 +/- ##
==========================================
- Coverage 87.50% 87.50% -0.01%
==========================================
Files 203 203
Lines 35609 35611 +2
==========================================
Hits 31160 31160
- Misses 4449 4451 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
raz-mon
approved these changes
Sep 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Manual backport of #6672 to
2.8.(cherry picked from commit 56f6f0e)
Changes:
test_gc_oom()to create index before adding the docs.test_gc_oom()to call set_tight_maxmemory_for_oom(env) instead ofenv.expect('config', 'set', 'maxmemory', 1).ok()useset_unlimited_maxmemory_for_oominstead ofenv.expect('config', 'set', 'maxmemory', 0).ok()`