Skip to content

[2.10] Fix "has map" performance - [MOD-9687]#6647

Merged
redisearch-backport-pull-request[bot] merged 2 commits into2.10from
backport-6636-to-2.10
Aug 13, 2025
Merged

[2.10] Fix "has map" performance - [MOD-9687]#6647
redisearch-backport-pull-request[bot] merged 2 commits into2.10from
backport-6636-to-2.10

Conversation

@redisearch-backport-pull-request
Copy link
Copy Markdown
Contributor

@redisearch-backport-pull-request redisearch-backport-pull-request bot commented Aug 13, 2025

Description

Backport of #6636 to 2.10.

GuyAv46 added 2 commits August 13, 2025 13:34
@GuyAv46 @github-actions
use cached value
2959f1f 
(cherry picked from commit 4ab8955)
@GuyAv46 @github-actions
make inline
56bd4be 
(cherry picked from commit e3082eb)
@redisearch-backport-pull-request redisearch-backport-pull-request bot mentioned this pull request Aug 13, 2025
Merged
2 tasks
@fcostaoliveira
Copy link
Copy Markdown
Contributor

fcostaoliveira commented Aug 13, 2025 •
edited
Loading

Automated performance analysis summary

This comment was automatically generated given there is performance data available.

In summary:

  • Detected a total of 28 stable tests between versions.
  • Detected a total of 11 highly unstable benchmarks (11 baseline).
  • Latency analysis confirmed regressions in 2 of the unstable tests:
  • Detected a total of 1 improvements above the improvement water line.

You can check a comparison in detail via the grafana link

Performance Improvements - Comparison between 2.10 and backport-6636-to-2.10.

Time Period from 30 days ago. (environment used: oss-standalone)

Test Case Baseline 2.10 (median obs. +- std.dev) Comparison backport-6636-to-2.10 (median obs. +- std.dev) % change (higher-better) Note
ftsb-10K-enwiki_abstract-hashes-term-prefix 8718 +- 6.6% (7 datapoints) 9711 11.4% IMPROVEMENT

Performance Regressions and Issues - Comparison between 2.10 and backport-6636-to-2.10.

Time Period from 30 days ago. (environment used: oss-standalone)

Test Case Baseline 2.10 (median obs. +- std.dev) Comparison backport-6636-to-2.10 (median obs. +- std.dev) % change (higher-better) Note
search-numeric-sortby-desc-optimize 47 +- 30.5% UNSTABLE (7 datapoints) 32 -32.8% UNSTABLE (baseline high variance); server: FT.SEARCH p50 increased 49.1% (baseline CV=26.2%); client: Latency increased 48.8% (baseline CV=25.9%)
search-numeric-sortby-desc 4206 +- 24.9% UNSTABLE (7 datapoints) 3524 -16.2% UNSTABLE (baseline high variance); server: FT.SEARCH p50 increased 20.0% (baseline CV=20.2%); client: Latency increased 19.3% (baseline CV=19.6%)
ftsb-1M-enwiki_abstract-hashes-fulltext-2word-intersection-query 377 +- 19.2% UNSTABLE (7 datapoints) 335 -11.0% UNSTABLE (baseline high variance); server: p50 latency stable; client: OverallQuantiles.allCommands.q50 increased 13.9% (baseline CV=20.7%); only client side confirms regression (server side stable) - insufficient evidence
ftsb-1M-enwiki_abstract-hashes-fulltext-2word-union-query 3399 +- 13.2% UNSTABLE (7 datapoints) 3239 -4.7% UNSTABLE (baseline high variance); server: p50 latency stable; client: OverallQuantiles.allCommands.q50 increased 5.2% (baseline CV=15.0%); neither server nor client side confirms regression
search-numeric-sortby 3786 +- 10.3% UNSTABLE (7 datapoints) 3858 1.9% UNSTABLE (baseline high variance); server: p50 latency stable; client: client latency stable; neither server nor client side confirms regression
vecsim-arxiv-titles-384-angular-filters-m16-ef-128-numeric-filter 123 +- 11.3% UNSTABLE (7 datapoints) 126 2.4% UNSTABLE (baseline high variance); server: p50 latency stable; client: client latency stable; neither server nor client side confirms regression
search-numeric 4256 +- 28.4% UNSTABLE (7 datapoints) 4435 4.2% UNSTABLE (baseline high variance); server: p50 latency stable; client: client latency stable; neither server nor client side confirms regression
search-filtering-tag-numeric 192 +- 15.3% UNSTABLE (7 datapoints) 219 13.6% UNSTABLE (baseline high variance); server: FT.AGGREGATE p50 decreased 11.4% (baseline CV=14.9%); client: Latency decreased 11.9% (baseline CV=14.8%); neither server nor client side confirms regression
ftsb-1M-enwiki_abstract-hashes-fulltext-2word-union-query-non-sortable 1078 +- 15.9% UNSTABLE (7 datapoints) 1389 28.8% UNSTABLE (baseline high variance); server: FT.SEARCH p50 decreased 6.7% (baseline CV=3.7%); client: OverallQuantiles.allCommands.q50 decreased 23.6% (baseline CV=12.7%); neither server nor client side confirms regression
ftsb-1M-enwiki_abstract-hashes-fulltext-simple-1word-query 854 +- 30.7% UNSTABLE (7 datapoints) 1294 51.5% UNSTABLE (baseline high variance); server: FT.SEARCH p50 decreased 31.3% (baseline CV=22.5%); client: OverallQuantiles.allCommands.q50 decreased 35.2% (baseline CV=22.1%); neither server nor client side confirms regression
ftsb-1M-enwiki_abstract-hashes-fulltext-2word-intersection-query-non-sortable 32 +- 23.4% UNSTABLE (7 datapoints) 52 64.8% UNSTABLE (baseline high variance); server: FT.SEARCH p50 decreased 24.7% (baseline CV=16.2%); client: OverallQuantiles.allCommands.q50 increased 10.7% (baseline CV=11.7%); only client side confirms regression (server side stable) - insufficient evidence
Tests with No Significant Changes (28 tests)

Tests with No Significant Changes

Test Case Baseline 2.10 (median obs. +- std.dev) Comparison backport-6636-to-2.10 (median obs. +- std.dev) % change (higher-better) Note
ftsb-10K-enwiki_abstract-hashes-fulltext-sortby 83 +- 2.7% (7 datapoints) 83.00 -0.0% No Change
ftsb-10K-enwiki_abstract-hashes-term-suffix 2659 +- 1.3% (7 datapoints) 2690.00 1.2% No Change
ftsb-10K-enwiki_abstract-hashes-term-suffix-withsuffixtrie 83957 +- 3.1% (7 datapoints) 90512.00 7.8% potential IMPROVEMENT
ftsb-10K-enwiki_abstract-hashes-term-wildcard 15595 +- 6.0% (7 datapoints) 16295.00 4.5% potential IMPROVEMENT
ftsb-10K-enwiki_pages-hashes-fulltext-mixed_simple-1word-query_write_1_to_read_20.yml 1341 +- 5.9% (7 datapoints) 1436.00 7.0% potential IMPROVEMENT
ftsb-10K-enwiki_pages-hashes-load 62835 +- 6.1% (7 datapoints) 59177.00 -5.8% potential REGRESSION
ftsb-10K-multivalue-numeric-json 1031 +- 2.1% (7 datapoints) 1025.00 -0.6% No Change
ftsb-10K-singlevalue-numeric-json 479 +- 0.9% (7 datapoints) 475.00 -0.7% No Change
ftsb-1K-enwiki_abstract-hashes-term-contains 2218 +- 1.3% (7 datapoints) 2276.00 2.6% No Change
ftsb-1M-enwiki_abstract-hashes-load 23682 +- 5.3% (7 datapoints) 25386.00 7.2% potential IMPROVEMENT
ftsb-1M-nyc_taxis-ftadd-load 31953 +- 2.9% (7 datapoints) 31354.00 -1.9% No Change
ftsb-1M-nyc_taxis-hashes-load 33357 +- 3.1% (7 datapoints) 32575.00 -2.3% No Change
search-aggregate-post-filter-simple.yml 129733 +- 5.4% (7 datapoints) 133388.00 2.8% No Change
search-filtering-tag-numeric-filter-pipeline 25217 +- 3.1% (7 datapoints) 26340.00 4.5% potential IMPROVEMENT
search-ftsb-10K-enwiki_abstract-hashes-term-withoutsuffix-trie 51300 +- 4.2% (7 datapoints) 54486.00 6.2% potential IMPROVEMENT
search-ftsb-10K-enwiki_abstract-hashes-term-withsuffix-trie 51399 +- 2.8% (7 datapoints) 49677.00 -3.4% potential REGRESSION
search-ftsb-1700K-docs-union-iterators-q3 7.6 +- 1.0% (7 datapoints) 7.50 -0.9% No Change
search-ftsb-1M-enwiki_abstract-hashes-fulltext-simple-1word-query-non-sortable 158 +- 7.4% (7 datapoints) 163.00 2.8% No Change
search-ftsb-370K-docs-union-iterators-q4 7.7 +- 1.1% (7 datapoints) 7.70 0.3% No Change
search-ftsb-5200K-docs-union-iterators-q1 0.78 +- 0.9% (7 datapoints) 0.79 1.3% No Change
search-ftsb-5500K-docs-union-iterators-q2 1.1 +- 1.4% (7 datapoints) 1.20 2.7% No Change
search-geo 238 +- 3.2% (7 datapoints) 236.00 -0.8% No Change
search-high-cardinality-negation-term-baseline 31 +- 4.5% (7 datapoints) 30.00 -0.9% No Change
search-high-cardinality-negation-term-comparison_union_all_other_terms 9.3 +- 3.1% (7 datapoints) 9.40 1.4% No Change
search-numeric-optimize 13821 +- 1.8% (7 datapoints) 13837.00 0.1% No Change
search-numeric-sortby-optimize 24 +- 1.4% (7 datapoints) 25.00 2.8% No Change
vecsim-arxiv-titles-384-angular-filters-m16-ef-128-fulltext-filter 654 +- 2.8% (7 datapoints) 670.00 2.4% No Change
vecsim-arxiv-titles-384-angular-filters-m16-ef-128-tag-filter 79747 +- 4.7% (7 datapoints) 74240.00 -6.9% potential REGRESSION

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 13, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.30%. Comparing base (1bc7d0d) to head (56bd4be).
⚠️ Report is 1 commits behind head on 2.10.

Additional details and impacted files 
@@            Coverage Diff             @@
##             2.10    #6647      +/-   ##
==========================================
- Coverage   89.31%   89.30%   -0.01%     
==========================================
  Files         206      206              
  Lines       36123    36123              
==========================================
- Hits        32263    32260       -3     
- Misses       3860     3863       +3
Flag Coverage Δ
flow 83.82% <100.00%> (-0.14%) ⬇️
unit 42.72% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@redisearch-backport-pull-request redisearch-backport-pull-request bot added this pull request to the merge queue Aug 13, 2025
Merged via the queue into 2.10 with commit a7b718b Aug 13, 2025
43 of 46 checks passed
@redisearch-backport-pull-request redisearch-backport-pull-request bot deleted the backport-6636-to-2.10 branch August 13, 2025 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GuyAv46 GuyAv46 GuyAv46 approved these changes

Assignees

No one assigned

Labels

action:run-benchmark bug size:XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fcostaoliveira @GuyAv46