Skip to content

[2.8] Fix "has map" performance - [MOD-9687]#6646

Merged
redisearch-backport-pull-request[bot] merged 2 commits into2.8from
backport-6636-to-2.8
Aug 13, 2025
Merged

[2.8] Fix "has map" performance - [MOD-9687]#6646
redisearch-backport-pull-request[bot] merged 2 commits into2.8from
backport-6636-to-2.8

Conversation

@redisearch-backport-pull-request
Copy link
Copy Markdown
Contributor

@redisearch-backport-pull-request redisearch-backport-pull-request bot commented Aug 13, 2025

Description

Backport of #6636 to 2.8.

GuyAv46 added 2 commits August 13, 2025 13:34
@GuyAv46 @github-actions
use cached value
1f19201 
(cherry picked from commit 4ab8955)
@GuyAv46 @github-actions
make inline
8e48940 
(cherry picked from commit e3082eb)
@redisearch-backport-pull-request redisearch-backport-pull-request bot mentioned this pull request Aug 13, 2025
Merged
2 tasks
@fcostaoliveira
Copy link
Copy Markdown
Contributor

fcostaoliveira commented Aug 13, 2025 •
edited
Loading

Automated performance analysis summary

This comment was automatically generated given there is performance data available.

In summary:

  • Detected a total of 23 stable tests between versions.
  • Detected a total of 13 highly unstable benchmarks.
  • Detected a total of 2 improvements above the improvement water line.
  • Detected a total of 2 regressions bellow the regression water line 5.0.

You can check a comparison in detail via the grafana link

Comparison between 2.8 and backport-6636-to-2.8.

Time Period from 30 days ago. (environment used: oss-standalone)

Test Case Baseline 2.8 (median obs. +- std.dev) Comparison backport-6636-to-2.8 (median obs. +- std.dev) % change (higher-better) Note
ftsb-10K-enwiki_abstract-hashes-fulltext-sortby 82 +- 6.5% (4 datapoints) 86.00 4.2% waterline=6.5%. potential IMPROVEMENT
ftsb-10K-enwiki_abstract-hashes-term-prefix 9123 +- 3.8% (4 datapoints) 9154.00 0.3% No Change
ftsb-10K-enwiki_abstract-hashes-term-suffix 2658 +- 0.3% (4 datapoints) 2680.00 0.8% No Change
ftsb-10K-enwiki_abstract-hashes-term-suffix-withsuffixtrie 86467 +- 2.6% (4 datapoints) 82692.00 -4.4% potential REGRESSION
ftsb-10K-enwiki_abstract-hashes-term-wildcard 14846 +- 12.8% UNSTABLE (4 datapoints) 15851.00 6.8% UNSTABLE (very high variance)
ftsb-10K-enwiki_pages-hashes-fulltext-mixed_simple-1word-query_write_1_to_read_20.yml 1393 +- 1.6% (4 datapoints) 1480.00 6.3% IMPROVEMENT
ftsb-10K-enwiki_pages-hashes-load 62770 +- 5.2% (4 datapoints) 63582.00 1.3% waterline=5.2%. No Change
ftsb-10K-multivalue-numeric-json 1082 +- 2.6% (4 datapoints) 1073.00 -0.8% No Change
ftsb-10K-singlevalue-numeric-json 496 +- 1.0% (4 datapoints) 492.00 -0.9% No Change
ftsb-1K-enwiki_abstract-hashes-term-contains 2220 +- 1.4% (4 datapoints) 2206.00 -0.7% No Change
ftsb-1M-enwiki_abstract-hashes-fulltext-2word-intersection-query 390 +- 28.7% UNSTABLE (4 datapoints) 264.00 -32.4% UNSTABLE (very high variance)
ftsb-1M-enwiki_abstract-hashes-fulltext-2word-intersection-query-non-sortable 36 +- 41.8% UNSTABLE (4 datapoints) 39.00 7.7% UNSTABLE (very high variance)
ftsb-1M-enwiki_abstract-hashes-fulltext-2word-union-query 3294 +- 18.6% UNSTABLE (4 datapoints) 3738.00 13.5% UNSTABLE (very high variance)
ftsb-1M-enwiki_abstract-hashes-fulltext-2word-union-query-non-sortable 1169 +- 19.2% UNSTABLE (4 datapoints) 970.00 -17.1% UNSTABLE (very high variance)
ftsb-1M-enwiki_abstract-hashes-fulltext-simple-1word-query 841 +- 27.3% UNSTABLE (4 datapoints) 1184.00 40.8% UNSTABLE (very high variance)
ftsb-1M-enwiki_abstract-hashes-load 25443 +- 8.2% (4 datapoints) 22864.00 -10.1% waterline=8.2%. REGRESSION
ftsb-1M-nyc_taxis-ftadd-load 31997 +- 3.6% (4 datapoints) 30841.00 -3.6% potential REGRESSION
ftsb-1M-nyc_taxis-hashes-load 34581 +- 1.8% (4 datapoints) 32983.00 -4.6% potential REGRESSION
search-aggregate-post-filter-simple.yml 116902 +- 6.1% (4 datapoints) 128884.00 10.2% waterline=6.1%. IMPROVEMENT
search-filtering-tag-numeric 203 +- 10.7% UNSTABLE (4 datapoints) 220.00 8.5% UNSTABLE (very high variance)
search-filtering-tag-numeric-filter-pipeline 26186 +- 1.5% (4 datapoints) 26798.00 2.3% No Change
search-ftsb-10K-enwiki_abstract-hashes-term-withoutsuffix-trie 51581 +- 4.2% (4 datapoints) 54137.00 5.0% potential IMPROVEMENT
search-ftsb-10K-enwiki_abstract-hashes-term-withsuffix-trie 53074 +- 2.8% (4 datapoints) 50802.00 -4.3% potential REGRESSION
search-ftsb-1700K-docs-union-iterators-q3 7.7 +- 1.3% (4 datapoints) 7.60 -0.8% No Change
search-ftsb-1M-enwiki_abstract-hashes-fulltext-simple-1word-query-non-sortable 150 +- 10.0% UNSTABLE (4 datapoints) 168.00 12.0% UNSTABLE (very high variance)
search-ftsb-370K-docs-union-iterators-q4 7.7 +- 0.6% (4 datapoints) 7.60 -1.2% No Change
search-ftsb-5200K-docs-union-iterators-q1 0.79 +- 0.7% (4 datapoints) 0.78 -0.6% No Change
search-ftsb-5500K-docs-union-iterators-q2 1.1 +- 0.9% (4 datapoints) 1.10 -1.7% No Change
search-geo 239 +- 3.1% (4 datapoints) 240.00 0.2% No Change
search-high-cardinality-negation-term-baseline 31 +- 8.9% (4 datapoints) 28.00 -10.6% waterline=8.9%. REGRESSION
search-high-cardinality-negation-term-comparison_union_all_other_terms 9.8 +- 1.2% (4 datapoints) 9.40 -3.9% potential REGRESSION
search-numeric 4047 +- 31.1% UNSTABLE (4 datapoints) 4105.00 1.4% UNSTABLE (very high variance)
search-numeric-optimize 14013 +- 2.3% (4 datapoints) 13781.00 -1.7% No Change
search-numeric-sortby 3667 +- 19.2% UNSTABLE (4 datapoints) 3805.00 3.8% UNSTABLE (very high variance)
search-numeric-sortby-desc 3737 +- 42.5% UNSTABLE (4 datapoints) 3778.00 1.1% UNSTABLE (very high variance)
search-numeric-sortby-desc-optimize 48 +- 33.6% UNSTABLE (4 datapoints) 71.00 48.2% UNSTABLE (very high variance)
search-numeric-sortby-optimize 24 +- 2.9% (4 datapoints) 24.00 -0.4% No Change
vecsim-arxiv-titles-384-angular-filters-m16-ef-128-fulltext-filter 662 +- 6.7% (4 datapoints) 670.00 1.2% waterline=6.7%. No Change
vecsim-arxiv-titles-384-angular-filters-m16-ef-128-numeric-filter 131 +- 12.7% UNSTABLE (4 datapoints) 132.00 0.5% UNSTABLE (very high variance)
vecsim-arxiv-titles-384-angular-filters-m16-ef-128-tag-filter 76811 +- 4.9% (4 datapoints) 76825.00 0.0% No Change

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 13, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.49%. Comparing base (6d3adcd) to head (8e48940).
⚠️ Report is 1 commits behind head on 2.8.

Additional details and impacted files 
@@            Coverage Diff             @@
##              2.8    #6646      +/-   ##
==========================================
- Coverage   87.49%   87.49%   -0.01%     
==========================================
  Files         202      202              
  Lines       35592    35592              
==========================================
- Hits        31142    31141       -1     
- Misses       4450     4451       +1
Flag Coverage Δ
flow 81.81% <100.00%> (-0.22%) ⬇️
unit 42.75% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@redisearch-backport-pull-request redisearch-backport-pull-request bot added this pull request to the merge queue Aug 13, 2025
Merged via the queue into 2.8 with commit 8135532 Aug 13, 2025
34 of 42 checks passed
@redisearch-backport-pull-request redisearch-backport-pull-request bot deleted the backport-6636-to-2.8 branch August 13, 2025 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GuyAv46 GuyAv46 GuyAv46 approved these changes

Assignees

No one assigned

Labels

action:run-benchmark bug size:XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fcostaoliveira @GuyAv46