[MOD-5935] Log DocTable capacity growth for memory diagnostics#6620
Merged
[MOD-5935] Log DocTable capacity growth for memory diagnostics#6620
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6620 +/- ##
==========================================
- Coverage 87.47% 87.45% -0.03%
==========================================
Files 282 282
Lines 44842 44843 +1
Branches 7747 7747
==========================================
- Hits 39226 39216 -10
- Misses 5498 5509 +11
Partials 118 118
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
alonre24
reviewed
Aug 12, 2025
Comment on lines
+136
to
+139
| // Log DocTable capacity growth to help diagnose cases where a small number of documents | ||
| // combined with frequent updates cause disproportionate memory usage. | ||
| // This allows us to confirm if unexpected memory spikes are due to capacity increases. | ||
| RedisModule_Log(RSDummyContext, "notice", "DocTable capacity increase from %zu to %zu", oldcap, t->cap); |
Collaborator
There was a problem hiding this comment.
Nice
I would just add a comment about the reason WHY we are not shrinking (avoiding rehashing..), and refer to the relevant config if we do want to shrink
alonre24
approved these changes
Aug 12, 2025
Contributor
|
Successfully created backport PR for |
Contributor
|
Successfully created backport PR for |
Contributor
|
Successfully created backport PR for |
Contributor
|
Successfully created backport PR for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a notice log in DocTable to record capacity increases:
This is meant to help diagnose a specific customer case where a small number of documents combined with a high volume of updates causes the DocTable size to grow disproportionately to the actual data stored (like in MOD-5935). The log will help confirm whether excessive capacity growth is contributing to the observed memory usage.