Merged
Conversation
* fix cursorList_Empty to mark delete instead of instant delete * remove redundant GC call * remove unused destroy * remove Destroy from h file * update owernship test * fix comments * expand test to multiple cursors * fix loop * use std::vector and std::find
GuyAv46
previously approved these changes
Aug 6, 2025
GuyAv46
previously approved these changes
Aug 6, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 2.6 #6604 +/- ##
==========================================
- Coverage 86.41% 86.37% -0.04%
==========================================
Files 185 185
Lines 32252 32251 -1
==========================================
- Hits 27869 27856 -13
- Misses 4383 4395 +12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
GuyAv46
approved these changes
Aug 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #6594 to 2.6.