Skip to content

Type for normalized (utf case folded) Strings in Rust - MOD-9985#6427

Closed
DarthB wants to merge 2 commits intomasterfrom
normalized_string_rust
Closed

Type for normalized (utf case folded) Strings in Rust - MOD-9985#6427
DarthB wants to merge 2 commits intomasterfrom
normalized_string_rust

Conversation

@DarthB
Copy link
Copy Markdown
Contributor

@DarthB DarthB commented Jul 3, 2025

Describe the changes in the pull request

To ensure safety, we want to encapsulate strings in a NormalizedString type that ensures that the underlying string representation is normalized, and thus sortable.

This is extracted from: #6311

Mark if applicable

  • This PR introduces API changes
  • This PR introduces serialization changes

@github-actions github-actions bot added the size:M label Jul 3, 2025
@DarthB DarthB added the enforce:coverage Run coverage flow even on draft pull request label Jul 3, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 3, 2025

Codecov Report

❌ Patch coverage is 44.00000% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.34%. Comparing base (9948b8d) to head (42c2295).
⚠️ Report is 433 commits behind head on master.

Files with missing lines Patch % Lines
...isearch_rs/sorting_vector/src/normalized_string.rs 44.00% 14 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6427      +/-   ##
==========================================
- Coverage   89.37%   89.34%   -0.04%     
==========================================
  Files         252      253       +1     
  Lines       41647    41672      +25     
  Branches     3963     3988      +25     
==========================================
+ Hits        37224    37231       +7     
- Misses       4366     4384      +18     
  Partials       57       57              
Flag Coverage Δ
flow 81.98% <ø> (-0.13%) ⬇️
unit 47.30% <44.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Jul 3, 2025

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Sep 6, 2025

This pull request is stale because it has been open for 60 days with no activity.

@github-actions github-actions bot added the stale label Sep 6, 2025
@DarthB DarthB closed this Nov 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enforce:coverage Run coverage flow even on draft pull request size:M stale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants