String normalization becomes caller responsibility - MOD-9985#6426
Merged
String normalization becomes caller responsibility - MOD-9985#6426
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6426 +/- ##
==========================================
- Coverage 89.31% 89.25% -0.06%
==========================================
Files 251 251
Lines 41298 41301 +3
Branches 3614 3614
==========================================
- Hits 36884 36863 -21
- Misses 4370 4394 +24
Partials 44 44
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2 tasks
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the changes in the pull request
String normalization / case folding was part of the put_string method of the RSSortingVector.
Move the code for string normalization outside of
RSSortingVector, leading to a better division of concerns and also simplifying the C interface and upcoming Rust FFI code.Is extracted from: #6311
Main objects this PR modified
Mark if applicable