[8.0] MOD-10153: New APPLY function case()#6355
Merged
redisearch-backport-pull-request[bot] merged 3 commits into8.0from Jun 26, 2025
Merged
[8.0] MOD-10153: New APPLY function case()#6355redisearch-backport-pull-request[bot] merged 3 commits into8.0from
redisearch-backport-pull-request[bot] merged 3 commits into8.0from
Conversation
* WIP: Implement func_case * Add tests * Test nested case * Rename testNestedCase to testNestedCaseAndGroup * Add test for invalid apply expressions * Remove TODO comment * Fix flaky test * Test with document which doesn't have neither of the fields. * Add unit tests * Add tests for NULL and missing fields * Add more unit tests * refactor evalFuncCase and update test cases for func_case handling * Fix typo * Refactor testCaseWithLogicalOperators and testCaseWithMissingFields to improve product classification and result validation * Add test with deep nesting of case * One more simple test --------- Co-authored-by: oshadmi <omer.shadmi@redis.com> (cherry picked from commit f338602)
2 tasks
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 8.0 #6355 +/- ##
==========================================
- Coverage 88.84% 88.83% -0.01%
==========================================
Files 201 201
Lines 37422 37441 +19
==========================================
+ Hits 33246 33262 +16
- Misses 4176 4179 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
nafraf
approved these changes
Jun 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport of #6332 to
8.0.Changes:
case()is guarded by search-enable-unstable-features