Skip to content

Refactor Iterators#5619

Closed
GuyAv46 wants to merge 34 commits intomasterfrom
guyav-refactor_iterators
Closed

Refactor Iterators#5619
GuyAv46 wants to merge 34 commits intomasterfrom
guyav-refactor_iterators

Conversation

@GuyAv46
Copy link
Copy Markdown
Collaborator

@GuyAv46 GuyAv46 commented Feb 8, 2025

Describe the changes in the pull request

A clear and concise description of what the PR is solving, including:

  1. Current: The current state briefly
  2. Change: What is the change
  3. Outcome: Adding the outcome

Which additional issues this PR fixes

  1. MOD-...
  2. #...

Main objects this PR modified

  1. ...

Mark if applicable

  • This PR introduces API changes
  • This PR introduces serialization changes

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 8, 2025

Codecov Report

Attention: Patch coverage is 93.88298% with 46 lines in your changes missing coverage. Please review.

Project coverage is 87.99%. Comparing base (c29e9bc) to head (9abd847).
Report is 37 commits behind head on master.

Files with missing lines Patch % Lines
src/index.c 94.01% 32 Missing ⚠️
src/geometry/query_iterator.cpp 83.33% 3 Missing ⚠️
src/id_list.c 85.71% 3 Missing ⚠️
src/optimizer_reader.c 90.00% 3 Missing ⚠️
src/numeric_index.c 77.77% 2 Missing ⚠️
src/hybrid_reader.c 97.50% 1 Missing ⚠️
src/inverted_index.c 97.36% 1 Missing ⚠️
src/redisearch_api.c 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5619      +/-   ##
==========================================
+ Coverage   87.27%   87.99%   +0.71%     
==========================================
  Files         196      197       +1     
  Lines       35288    35077     -211     
==========================================
+ Hits        30798    30865      +67     
+ Misses       4490     4212     -278     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GuyAv46 GuyAv46 marked this pull request as draft February 10, 2025 10:54
raz-mon
raz-mon previously approved these changes Feb 11, 2025
@raz-mon raz-mon dismissed their stale review February 11, 2025 15:05

By accident

@GuyAv46 GuyAv46 marked this pull request as ready for review February 11, 2025 19:13
@GuyAv46 GuyAv46 marked this pull request as draft February 11, 2025 19:14
@DvirDukhan
Copy link
Copy Markdown

@GuyAv46 can we close it since you epiced it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants