[8.0] Improve query parsing - [MOD-7794, MOD-7764] (#5216)#5251
Merged
Conversation
* general cleanup and improvements * validate field in the parser * drop legacy geo and numeric filters * fix unit tests * test fixes * cleanup and v1 bug fix * another test fix * missed cleanup * skip config test on coord * add numeric validation min <= max * remove redundant code * fix more unit-tests * fix flow tests again * fix unit-test again * leak fixes * improve coverage * addressing some review comments * fix after merging master (cherry picked from commit d67d645)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 8.0 #5251 +/- ##
==========================================
+ Coverage 86.55% 86.59% +0.03%
==========================================
Files 192 192
Lines 34484 34410 -74
==========================================
- Hits 29849 29797 -52
+ Misses 4635 4613 -22 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
alonre24
approved these changes
Nov 25, 2024
raz-mon
approved these changes
Nov 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport of #5216 to
8.0.