Conversation
Codecov Report
@@ Coverage Diff @@
## master #1891 +/- ##
==========================================
+ Coverage 80.30% 80.32% +0.02%
==========================================
Files 148 148
Lines 21504 21528 +24
==========================================
+ Hits 17269 17293 +24
Misses 4235 4235
Continue to review full report at Codecov.
|
oshadmi
approved these changes
Mar 24, 2021
Collaborator
oshadmi
left a comment
There was a problem hiding this comment.
👍🏼 Thanks also for the clarifications!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this change, when a search was with a limit of 0,
Scorer,Sorterand usuallyLoader ResultProcessorswould be created which consume cpu time.This PR replaces them with a
CounterRP which adds to the count and frees theSearchResultcontent.