Fix flaky test (#5079)

GuyAv46 · web-flow · commit f37d21f96eee · 2024-10-07T09:33:11.000Z
* fix flakiness

* revert whitespace change

* add comments
diff --git a/tests/pytests/test_json.py b/tests/pytests/test_json.py
@@ -617,8 +617,17 @@ def test_JSON_RDB_load_fail_without_JSON_module(env: Env):
     env.envRunner.modulePath.pop() # Assumes Search module is the first and JSON module is the second
     env.envRunner.moduleArgs.pop()
     env.envRunner.masterCmdArgs = env.envRunner.createCmdArgs('master')
-    env.start() # Restart without JSON module. Attempt to load RDB
-    env.assertFalse(env.isUp()) # Server is down with no assertion error (MOD-7587)
+    # Restart without JSON module. Attempt to load RDB - should fail.
+    # RLTest may or may not fail to start the server with an exception
+    try:
+        env.start()
+    except Exception as e:
+        expected_msg = 'Redis server is dead'
+        env.assertContains(expected_msg, str(e))
+        if expected_msg not in str(e):
+            raise e
+    finally:
+        env.assertFalse(env.isUp()) # Server is down with no assertion error (MOD-7587)
 
 @skip(msan=True, no_json=True)
 def testIndexSeparation(env):
