Merged
Conversation
… always dropped and the stream would potentially end one frame early. If passed a null file, throw an exception and bail out instead of trying to continue. hasMoreTags() ignored the firstTags queue (metadata/decoder-config). If frame analysis fails or yields zero frames, callers would see false and never receive the metadata/config tags that were prepared. The reader actually parses .f4a, .m4a and .mp4 files, but the extensions the service advertised accepting included .aac instead of .mp4, which didn't actually work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit from kdkd fork
1cb28ddM4AReader: Frames are 0 indexed not 1 indexed, so the first frame was always dropped and the stream would potentially end one frame early.
If passed a null file, throw an exception and bail out instead of trying to continue.
hasMoreTags() ignored the firstTags queue (metadata/decoder-config). If
frame analysis fails or yields zero frames, callers would see false and never
receive the metadata/config tags that were prepared.
The reader actually parses .f4a, .m4a and .mp4 files, but the extensions the service
advertised accepting included .aac instead of .mp4, which didn't actually work.