Merged
Conversation
…istener
with listener.getClass().isInstance(clazz), but isInstance expects an
object, not a Class. This always returned false, so listeners were never
detected. As a result, code that relies on this check (e.g., avoiding
duplicate registration or verifying protocol handler availability)
silently failed. Check adjusted to match function return type.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit from kdkd fork
87fdaef/net/websocket/WebSocketScope.java: attempted to detect an existing listener with listener.getClass().isInstance(clazz), but isInstance expects an object, not a Class. This always returned false, so listeners were never detected. As a result, code that relies on this check (e.g., avoiding duplicate registration or verifying protocol handler availability) silently failed. Check adjusted to match function return type.