Make sure we're not at EOF in more places in TLS reads#396
Merged
Conversation
InputStream readers for uint16/24/32 only checked the last byte for EOF. If the stream ended on the first or middle byte, the methods return a value built from -1 bytes instead of throwing, leading to silent truncation and incorrect protocol parsing (potentially accepting malformed handshakes).
mondain
approved these changes
Nov 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit from kdkd fork
03529a8io/utils/TlsUtils.java:
InputStream readers for uint16/24/32 only checked the last byte for EOF. If
the stream ended on the first or middle byte, the methods return a value
built from -1 bytes instead of throwing, leading to silent truncation and
incorrect protocol parsing (potentially accepting malformed handshakes).