Merged
Conversation
AMF decided to allow negative length strings and arrays. If the client tries these shenanigans, just treat it as a 0 length object instead of believing them. Add a few checks to make sure we aren't reading past the end of the packet if it ends too early. Also don't let a client claim it's going to send a 2 billion arrays to trick us into allocation 2 billion items to store them in.
This comment was marked as spam.
This comment was marked as spam.
mondain
approved these changes
Nov 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked commits
Commit
a449f7bAdditional sanity checks on AMF packets.
AMF decided to allow negative length strings and arrays. If the client
tries these shenanigans, just treat it as a 0 length object instead of
believing them.
Add a few checks to make sure we aren't reading past the end of the packet
if it ends too early.
Also don't let a client claim it's going to send a 2 billion arrays to
trick us into allocation 2 billion items to store them in.