Permalink
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
...
- 3 commits
- 16 files changed
- 1 contributor
Commits on Jan 8, 2026
-
-
Fix RTMP extended timestamp handling for origin-to-edge streaming
Two issues were causing chunk stream desynchronization in Red5-to-Red5 cluster communication: 1. Type 0 header decoding did not reset extended=false when wire timestamp dropped below MEDIUM_INT_MAX (16777215). This caused the flag to be incorrectly inherited from previous headers, making Type 3 chunks read 4 extra bytes when they shouldn't. 2. A "compatibility check" in Type 3 handling used decoded timestamp values (which include discontinuity offsets) instead of wire values, causing false positives that read extra bytes. Also documented that RTMPProtocolDecoder.decodeBuffer() already calls compact() in its finally block - callers should NOT compact again as double-compact corrupts buffer positions. Fixes: - Add else clause to Type 0 to reset extended=false when timestamp < MEDIUM_INT_MAX - Remove faulty compatibility check from Type 3 that checked adjusted values - Add comments in Mina decoders warning against double-compact - Add debug logging for Type 3 extended timestamp encoding - Add unit test for extended-to-non-extended timestamp transition
-
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v2.0.28...v2.0.29